[PATCH] D133085: [clang] trim trailing space in format tests. NFC

Thu Sep 1 04:09:30 PDT 2022

aaron.ballman added a comment.

In D133085#3763233 <https://reviews.llvm.org/D133085#3763233>, @inclyc wrote:

> In D133085#3763198 <https://reviews.llvm.org/D133085#3763198>, @ChuanqiXu wrote:
>
>> Do you have commit access? If you have, I remember LLVM encourages to land such fixes directly without reviewed. (+ @aaron.ballman to make sure)
>
> Thanks! I'm just not sure whether these changes are necessary or not. :)

It's always okay to do an NFC commit which strips trailing whitespace, fixes a typo or misspelling, adds/removes newlines, or that sort of change in a targeted way. No need to review it unless you want a second set of eyes on the changes for some reason. We typically don't want a whole-project NFC change to do that sort of thing, though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133085/new/

https://reviews.llvm.org/D133085