[PATCH] D132142: [analyzer] Prefer wrapping SymbolicRegions by ElementRegions

[Balázs Benics via Phabricator via cfe-commits]

steakhal added inline comments.


================
Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:799
+  /// we actually know their types.
+  QualType getApproximatedType() const {
+    return sym->getType()->getPointeeType();
----------------
martong wrote:
> I think we should express that this returns the
> 
> 
>   - type of the pointee
>   - the type that is the "static" type, id est, the type of the declaration; `void`, `char` and `base` in your example above.
> 
> In this sense, what about `getPointeeStaticType`?
> 
> 
I think it's important to discourage people from using this; hence the `approximated` calls attention that this might always be accurate.
I'm okay to add the `pointee` somewhere in the name.

I don't have a strong opinion about this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132142/new/

https://reviews.llvm.org/D132142