[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

Wed Aug 31 19:15:43 PDT 2022

luken-google added a comment.

In D133052#3762596 <https://reviews.llvm.org/D133052#3762596>, @ychen wrote:

> Like mentioned in https://stackoverflow.com/questions/68853472/is-this-a-bug-in-clangs-c20-concepts-implementation-unnecessary-checking-of, could we not go down the path of considering conversion candidates? It seems that's blessed by the standard.

If I'm understanding the code correctly, the intent of this patch is to definitely consider conversion candidates, only to exclude those conversion candidates that are templated methods where the From type is the same as the To type, which to me mean they are possibly redundant?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133052/new/

https://reviews.llvm.org/D133052