[PATCH] D132971: [clang][modules] Don't hard code [no_undeclared_includes] for the Darwin module

Tue Aug 30 13:40:05 PDT 2022

iana added a comment.

In D132971#3759538 <https://reviews.llvm.org/D132971#3759538>, @Bigcheese wrote:

> I'm fine with this change, but do we actually have a backwards compatibility policy anywhere in Clang? Would be good to know what range of SDKs a compiler release is expected to support.

I don't know about backwards compatibility, but I found the Darwin module added the attribute in 2017 macOS 10.13/iOS 11.0. As far as I can tell from the original change, adding the attribute didn't actually fix anything, it was just used to detect cycles between libc++ and Darwin, so I think removing the hard code wouldn't even break older OSes.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132971/new/

https://reviews.llvm.org/D132971