[PATCH] D132405: [clang][deps] Split translation units into individual -cc1 or other commands

Tue Aug 30 13:29:52 PDT 2022

jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.

LGTM. Up to you if you act on the last comment. Thanks for seeing this through!

================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp:295
+    if (MDC)
+      MDC->applyDiscoveredDependencies(CI);
+    LastCC1Arguments = CI.getCC1CommandLine();
----------------
I'm not a fan of storing `MDC` as a member, but I don't see any clearly better alternatives. One option would be to pass `CompilerInvocation` out-parameter to `ModuleDepCollector`'s constructor and relying on the collector to apply discovered dependencies, but that's not super obvious.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132405/new/

https://reviews.llvm.org/D132405