[PATCH] D132962: [clangd][ObjC] Improve completions for protocols + category names

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 30 11:26:46 PDT 2022


dgoldman created this revision.
dgoldman added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
dgoldman requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.

- Render protocols as interfaces to differentiate them from classes since a protocol and class can have the same name

- Properly call `includeSymbolFromIndex` even with a cached speculative fuzzy find request

- Don't use the index to provide completions for category names, symbols there don't make sense


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132962

Files:
  clang-tools-extra/clangd/CodeComplete.cpp
  clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132962.456737.patch
Type: text/x-patch
Size: 4487 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220830/a1378649/attachment.bin>


More information about the cfe-commits mailing list