[PATCH] D132932: [Clang][Comments] Parse `<img src=""/>` in doc comments correctly
Egor Zhdan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 30 10:02:37 PDT 2022
egorzhdan marked an inline comment as done.
egorzhdan added inline comments.
================
Comment at: clang/tools/libclang/CXString.cpp:85
+ if (String.empty())
+ return createEmpty();
+
----------------
gribozavr2 wrote:
> Please split this change into a separate patch and add a unit test.
>
Do you know a good way to add a unit-test for this? This function only gets called from within libclang, it isn't exposed to clients of libclang, including libclangTest. So I think a unit test would probably need to invoke the same CXComment API that `c-index-test` invokes while running `comment-to-html-xml-conversion.cpp`. Would that be worth it?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132932/new/
https://reviews.llvm.org/D132932
More information about the cfe-commits
mailing list