[PATCH] D132919: [clangd] Enable folding ranges by default.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 30 02:26:43 PDT 2022


kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:340
     desc("Enable preview of FoldingRanges feature"),
-    init(false),
+    init(true),
     Hidden,
----------------
i think we should just retire the flag altogether, ATM this is only preventing clangdlspserver from announcing the capability.

the only benefit of keeping it as a flag is, we can turn it off quickly if its crashing constantly. but we should fix those crashes instead. so do you mind:
- moving it to be near other retiredflags (around line 320)
- always announce foldingrangeprovider capability and bind the method in clangdlspserver.cpp
- get rid of the option inside clangdserver.h


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132919/new/

https://reviews.llvm.org/D132919



More information about the cfe-commits mailing list