[PATCH] D129833: Use @llvm.threadlocal.address intrinsic to access TLS

Mon Aug 29 20:02:38 PDT 2022

ChuanqiXu added a comment.

In D129833#3755135 <https://reviews.llvm.org/D129833#3755135>, @nikic wrote:

> In D129833#3727881 <https://reviews.llvm.org/D129833#3727881>, @ChuanqiXu wrote:
>
>> And I am working on adding Align properties. But I meet problems since the alignment of threadlocal_address intrinsic depends on its argument so we can't set the alignment for its declaration and we probably need to set the alignment for its call, which means we need to set the alignment when in IRBuilder. Do you think this is good?
>
> I think that would be fine. Alternatively, it could be inferred in InstCombine.

Thanks. I've filed an issue for it: https://github.com/llvm/llvm-project/issues/57438. (I'll fix it later if I had time)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129833/new/

https://reviews.llvm.org/D129833