[PATCH] D128490: [ODRHash diagnostics] Transform method `ASTReader::diagnoseOdrViolations` into a class `ODRDiagsEmitter`. NFC.
    Volodymyr Sapsai via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Mon Aug 29 19:13:29 PDT 2022
    
    
  
vsapsai added a comment.
In D128490#3689958 <https://reviews.llvm.org/D128490#3689958>, @ChuanqiXu wrote:
> LGTM then.
Thanks for the review! Sorry for not answering earlier, I was on vacation. Now I'll rebase the change and will test it again before committing.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128490/new/
https://reviews.llvm.org/D128490
    
    
More information about the cfe-commits
mailing list