[PATCH] D132801: [driver] Additional ignoring of module-map related flags, if modules are disabled

Argyrios Kyrtzidis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 29 15:51:45 PDT 2022


akyrtzi marked an inline comment as done.
akyrtzi added inline comments.


================
Comment at: clang/test/Driver/modules.m:81
 
 // RUN: %clang -fno-modules -fmodules-validate-system-headers -### %s 2>&1 | FileCheck -check-prefix=VALIDATE_SYSTEM_FLAG %s
 // VALIDATE_SYSTEM_FLAG-NOT: -fmodules-validate-system-headers
----------------
MaskRay wrote:
> You may combine `-fmodule-map-file=module.modulemap` with this RUN line to avoid introducing a new RUN line (every run makes testsuite slightly slower).
Good suggestion, I merged the last existing 2 `RUN` lines along with the new one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132801/new/

https://reviews.llvm.org/D132801



More information about the cfe-commits mailing list