[PATCH] D132877: Downgrade the UAX31 diagnostic to a warning which defaults to an error

[Erich Keane via Phabricator via cfe-commits]

erichkeane added a comment.

In D132877#3756328 <https://reviews.llvm.org/D132877#3756328>, @efriedma wrote:

> If we don't specifically call out the deprecation period in the diagnostic, usage will grow beyond what we expect.  (Most people don't read the release notes; they'll just see it's possible to turn off the error message, and turn it off.)
>
> If we're okay with people deciding their own rules for what they want to allow in identifiers, we can just make the flag permanently available, though, and just drop the whole "deprecation period" discussion.  Or alternatively, we could add a separate diagnostic specifically for older standard modes: allow only the characters that were allowed by the older standards, and don't emit it for C++23 and newer.  That way, usage naturally goes away as people upgrade their code to newer standard modes.

IIRC, this was accepted as DR, so there are NO 'older standards' of C++ in which allow these characters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132877/new/

https://reviews.llvm.org/D132877