[PATCH] D131639: [OpenMP] Remove 'stdbool.h' from OpenMP header wrappers

Mon Aug 29 09:00:38 PDT 2022

ivanrodriguez3753 added a comment.

In D131639#3749633 <https://reviews.llvm.org/D131639#3749633>, @jhuber6 wrote:

> I think it's perfectly reasonable to include system files as part of a toolchain.

I think it comes down to a matter of inconveniencing the user versus the developer. We usually go with the latter. I don't particularly agree with your statement I quoted above, but I can't say I'm an expert in this area. I'll see what others have to say. I've already pulled this into our fork so it doesn't make a difference to us, but I did think it would be useful to get input from the community on whether or not we should pull this in to upstream.

Thanks for your input and responses.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131639/new/

https://reviews.llvm.org/D131639