[clang] a284f9f - [Driver] Don't pass --enable-new-dtags to ld for Android/openSUSE

Fangrui Song via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 28 11:38:48 PDT 2022


Author: Fangrui Song
Date: 2022-08-28T11:38:40-07:00
New Revision: a284f9febd9b8d7b2261f6c1db658292d03490a0

URL: https://github.com/llvm/llvm-project/commit/a284f9febd9b8d7b2261f6c1db658292d03490a0
DIFF: https://github.com/llvm/llvm-project/commit/a284f9febd9b8d7b2261f6c1db658292d03490a0.diff

LOG: [Driver] Don't pass --enable-new-dtags to ld for Android/openSUSE

This has been the default for a very long time.

Added: 
    

Modified: 
    clang/lib/Driver/ToolChains/Linux.cpp
    clang/test/Driver/linux-ld.c

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/ToolChains/Linux.cpp b/clang/lib/Driver/ToolChains/Linux.cpp
index cf5cdbcd86f34..169daa8e4b497 100644
--- a/clang/lib/Driver/ToolChains/Linux.cpp
+++ b/clang/lib/Driver/ToolChains/Linux.cpp
@@ -255,9 +255,6 @@ Linux::Linux(const Driver &D, const llvm::Triple &Triple, const ArgList &Args)
   ExtraOpts.push_back("--build-id");
 #endif
 
-  if (IsAndroid || Distro.IsOpenSUSE())
-    ExtraOpts.push_back("--enable-new-dtags");
-
   // The selection of paths to try here is designed to match the patterns which
   // the GCC driver itself uses, as this is part of the GCC-compatible driver.
   // This was determined by running GCC in a fake filesystem, creating all

diff  --git a/clang/test/Driver/linux-ld.c b/clang/test/Driver/linux-ld.c
index e76b35d6137c7..10e6bee183050 100644
--- a/clang/test/Driver/linux-ld.c
+++ b/clang/test/Driver/linux-ld.c
@@ -1068,7 +1068,6 @@
 // CHECK-ANDROID: "{{.*}}ld{{(.exe)?}}" "--sysroot=[[SYSROOT:[^"]+]]"
 // CHECK-ANDROID: "-z" "now"
 // CHECK-ANDROID: "-z" "relro"
-// CHECK-ANDROID: "--enable-new-dtags"
 // CHECK-ANDROID: "{{.*}}{{/|\\\\}}crtbegin_dynamic.o"
 // CHECK-ANDROID: "-L[[SYSROOT]]/usr/lib"
 // CHECK-ANDROID-NOT: "-lgcc_s"


        


More information about the cfe-commits mailing list