[PATCH] D132795: [clang-tidy] Tweak diagnostics for bugprone-assign-in-if-condition

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 27 15:08:10 PDT 2022


gribozavr2 accepted this revision.
gribozavr2 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clang-tidy/bugprone/AssignmentInIfConditionCheck.cpp:64
 
 void AssignmentInIfConditionCheck::report(const Expr *MatchedDecl) {
+  SourceLocation OpLoc =
----------------
Drive-by comment -- an Expr is not a Decl (feel free to defer to a separate patch).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132795/new/

https://reviews.llvm.org/D132795



More information about the cfe-commits mailing list