[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 22:18:50 PDT 2022


tbaeder added a comment.

In D132136#3751702 <https://reviews.llvm.org/D132136#3751702>, @erichkeane wrote:

> Would be great if we had a better test here... is there anything we can do to validate this is happening other than checking for that one note?

`EvaluateAsRValue` is called from `Expr::EvaluateAsRValue()`, so I think it would be possible to write a unittest for this. But I think that would be a lot of effort just to test this. There is even `unittests/AST/EvaluateAsRValueTest.cpp` already, but it tests the wrong thing :(


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132136/new/

https://reviews.llvm.org/D132136



More information about the cfe-commits mailing list