[clang] e877b42 - [clang] Better warning-fix follow-up to D131632

Nico Weber via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 15:30:53 PDT 2022


Author: Nico Weber
Date: 2022-08-26T18:29:20-04:00
New Revision: e877b42e2c70813352c1963ea33e992f481d5cba

URL: https://github.com/llvm/llvm-project/commit/e877b42e2c70813352c1963ea33e992f481d5cba
DIFF: https://github.com/llvm/llvm-project/commit/e877b42e2c70813352c1963ea33e992f481d5cba.diff

LOG: [clang] Better warning-fix follow-up to D131632

Not all host compilers understand gnu:: attributes. Just remove the
variable until it's used.

Added: 
    

Modified: 
    clang/lib/Frontend/SARIFDiagnostic.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Frontend/SARIFDiagnostic.cpp b/clang/lib/Frontend/SARIFDiagnostic.cpp
index f0f32a179825..416e9132afaf 100644
--- a/clang/lib/Frontend/SARIFDiagnostic.cpp
+++ b/clang/lib/Frontend/SARIFDiagnostic.cpp
@@ -71,8 +71,7 @@ SarifResult SARIFDiagnostic::addLocationToResult(
     FileID FID = Loc.getFileID();
     if (FID.isValid()) {
       if (const FileEntry *FE = Loc.getFileEntry()) {
-        [[gnu::unused]] llvm::StringRef Filename =
-            emitFilename(FE->getName(), Loc.getManager());
+        emitFilename(FE->getName(), Loc.getManager());
         // FIXME(llvm-project/issues/57366): File-only locations
       }
     }


        


More information about the cfe-commits mailing list