[PATCH] D132749: Expose QualType::getUnqualifiedType in libclang

[Luca Di sera via Phabricator via cfe-commits]

diseraluca added a comment.

I recently encountered a few cases, at work, as an employee of The Qt Company, where we would have liked to have access to `getUnqualifiedType` in libclang.

I found a precedence on the old mailing list, from 2018 (https://lists.llvm.org/pipermail/cfe-dev/2018-February/056874.html), for a similar request, where it seemed it wouldn't be disruptive to expose it to libclang.

This is my first contribution to llvm-project, so I apologize if I missed some requirement or pushed a patch that is incorrect. 
I'm obviously open to spend more time on this patch if there is something that should be modified.

Originally the patch contained the addition of `clang_getNonReferenceType` too, as that is something else that we would like to have access to.
I avoided including it into this patch because:

- As I understand it, having both in one patch would not comply with the isolated changes requirement in https://www.llvm.org/docs/Contributing.html#how-to-submit-a-patch.
- I could not find any precedence for requesting that specific interface and am unsure if the correct etiquette requires that a discussion is opened BEFORE pushing this kind of patch.
- First pushing a smaller patch would allow me to get accustomed to the contributing workflow and understand what I might have done incorrectly, so as to push an higher quality patch.

Any clarification on if a patch that exposes `getNonReferencedType` requires a discussion to be opened before being pushed for acceptance and review is appreciated.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132749/new/

https://reviews.llvm.org/D132749