[PATCH] D131979: [clang][UBSan] Fix __builtin_assume_aligned crash

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 09:36:03 PDT 2022


rjmccall added a comment.

I'm a little worried about the shift to emit an unconditional error on `volatile`.  Can we at least separate that into its own patch and just fix the bug in this one?  And please try to reach out whoever originally added this feature to see if that restriction is okay vs. just ignoring it, because it certainly looks like the `volatile` exception was intentionally designed.

Other than that, this looks great, thank you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131979/new/

https://reviews.llvm.org/D131979



More information about the cfe-commits mailing list