[PATCH] D131154: FoldingRanges: Handle LineFoldingsOnly clients.

Utkarsh Saxena via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 08:33:07 PDT 2022


usaxena95 added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/SemanticSelectionTests.cpp:391
+        /* No folding for this comment.
+        */ int b_token=0;
+      )cpp",
----------------
kadircet wrote:
> it'd be nice to have a test case like:
> ```
> template <[[typename foo, class bar]]> struct baz {[[]]};
> ```
> 
> which isn't useful for line-only folding clients, but something we should be able to support going forward.
I don't understand. We do not return any single-line ranges.
I think lines are never long enough to have helpful foldings (atleast in formatted code). It would only clutter  IMO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131154/new/

https://reviews.llvm.org/D131154



More information about the cfe-commits mailing list