[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 07:24:47 PDT 2022


jhuber6 added inline comments.


================
Comment at: clang/tools/clang-offload-packager/ClangOffloadPackager.cpp:17-21
+#include "llvm/IR/Constants.h"
+#include "llvm/IR/Module.h"
+#include "llvm/IRReader/IRReader.h"
+#include "llvm/Object/Archive.h"
+#include "llvm/Object/ArchiveWriter.h"
----------------
yaxunl wrote:
> Are these include files necessary? I do not see code changes that need new include files. Or they were missing before?
You're right, they were included previously but I since rolled that logic into D132689. I'll remove them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132607/new/

https://reviews.llvm.org/D132607



More information about the cfe-commits mailing list