[clang] 01bebed - [Basic] Drop header-only dependency from Basic to Lex

Benjamin Kramer via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 07:04:47 PDT 2022


Author: Benjamin Kramer
Date: 2022-08-26T16:03:22+02:00
New Revision: 01bebedaf09bcb7b4f00b8d37a121e68316f9f59

URL: https://github.com/llvm/llvm-project/commit/01bebedaf09bcb7b4f00b8d37a121e68316f9f59
DIFF: https://github.com/llvm/llvm-project/commit/01bebedaf09bcb7b4f00b8d37a121e68316f9f59.diff

LOG: [Basic] Drop header-only dependency from Basic to Lex

It's still a bit weird for IdentifierTable to depend on Lex diagnostics,
but we can get away with including the enum info that's in Basic already.

Added: 
    

Modified: 
    clang/include/clang/Basic/IdentifierTable.h
    clang/lib/Basic/IdentifierTable.cpp

Removed: 
    


################################################################################
diff  --git a/clang/include/clang/Basic/IdentifierTable.h b/clang/include/clang/Basic/IdentifierTable.h
index 1e89aa5f670f..f98ea48f952f 100644
--- a/clang/include/clang/Basic/IdentifierTable.h
+++ b/clang/include/clang/Basic/IdentifierTable.h
@@ -15,9 +15,9 @@
 #ifndef LLVM_CLANG_BASIC_IDENTIFIERTABLE_H
 #define LLVM_CLANG_BASIC_IDENTIFIERTABLE_H
 
+#include "clang/Basic/DiagnosticIDs.h"
 #include "clang/Basic/LLVM.h"
 #include "clang/Basic/TokenKinds.h"
-#include "clang/Lex/LexDiagnostic.h"
 #include "llvm/ADT/DenseMapInfo.h"
 #include "llvm/ADT/SmallString.h"
 #include "llvm/ADT/StringMap.h"

diff  --git a/clang/lib/Basic/IdentifierTable.cpp b/clang/lib/Basic/IdentifierTable.cpp
index 5d413a8da6d3..3940d4bc5de3 100644
--- a/clang/lib/Basic/IdentifierTable.cpp
+++ b/clang/lib/Basic/IdentifierTable.cpp
@@ -13,6 +13,7 @@
 
 #include "clang/Basic/IdentifierTable.h"
 #include "clang/Basic/CharInfo.h"
+#include "clang/Basic/DiagnosticLex.h"
 #include "clang/Basic/LangOptions.h"
 #include "clang/Basic/OperatorKinds.h"
 #include "clang/Basic/Specifiers.h"


        


More information about the cfe-commits mailing list