[PATCH] D132727: [clang][Interp] Implement array initializers and subscript expressions

[Timm Bäder via Phabricator via cfe-commits]

tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:535
+
+  // TODO: Fillers?
+  if (const auto *InitList = dyn_cast<InitListExpr>(Initializer)) {
----------------
erichkeane wrote:
> Heh, THIS is a huge "TODO" here.  The ArrayFillers go through a ton of twists/turns in the current interpreter, as array-filler initializers can be massive.  Do we have a way to avoid allocating space for filled-but-not-referenced values in this interpreter?
Heh, believe me, I  know ;) I'd have to look into that, but I'm pretty sure the code as it is right now doesn't handle them at all.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132727/new/

https://reviews.llvm.org/D132727