[PATCH] D132723: [Clang] Fix crash in coverage of if consteval.

Corentin Jabot via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 05:58:06 PDT 2022


cor3ntin marked an inline comment as done.
cor3ntin added inline comments.


================
Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1407
       // The 'else' count applies to the area immediately after the 'then'.
-      Gap = findGapAreaBetween(getEnd(S->getThen()), getStart(Else));
+      auto Gap = findGapAreaBetween(getEnd(S->getThen()), getStart(Else));
       if (Gap)
----------------
aaron.ballman wrote:
> 1) Pick a name which doesn't shadow
> 2) Spell out the type instead of using `auto`
`auto Gap...` was preexisting, I changed both instances. Both variables are in their own non nested scopes though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132723/new/

https://reviews.llvm.org/D132723



More information about the cfe-commits mailing list