[PATCH] D132470: [pseudo] add the spurious left-and-upwads recovery case to unittest.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 26 04:14:38 PDT 2022


sammccall added inline comments.


================
Comment at: clang-tools-extra/pseudo/unittests/GLRTest.cpp:711
 
+TEST_F(GLRTest, SpuriousRecoveryLeftAndUpwardsCase) {
+  build(R"bnf(
----------------
it's not clear to me what this is testing, can you add some documentation?

(also I think "left" is spurious and "up" is correct, so why LeftAndUpwards rather than just left?)


================
Comment at: clang-tools-extra/pseudo/unittests/GLRTest.cpp:757
+            "[  2,   3) │     ├─{ := tok[2]\n"
+            "[  3,   8) │     ├─stmt-seq := <opaque>\n"
+            "[  8,   9) │     └─} := tok[8]\n"
----------------
this looks correct to me, what's the problem?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132470/new/

https://reviews.llvm.org/D132470



More information about the cfe-commits mailing list