[PATCH] D131919: Move googletest to the third-party directory

Paul Robinson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 25 17:23:15 PDT 2022


probinson added a comment.

In D131919#3749850 <https://reviews.llvm.org/D131919#3749850>, @Meinersbur wrote:

> Semi-OT: `polly\lib\External` has 3 more third-party libraries. Two of them have been heavily modified in-tree, the third has just a custom CMakeLists.txt.
> Should these eventually also be moved?

I don't know that there's a formal policy.  Our copy of googletest is used by several projects, so unhooking it from the llvm tree has value in that regard.
Heavy modification might not be a blocker; googletest is somewhat stripped-down, although otherwise I think only lightly modified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131919/new/

https://reviews.llvm.org/D131919



More information about the cfe-commits mailing list