[PATCH] D131683: Diagnosing the Future Keywords

Thu Aug 25 11:48:17 PDT 2022

aaron.ballman added a comment.

I spotted one last (hopefully) concern, but otherwise this LG for functionality. Can you also add a release note for the improved diagnostic behavior?

================
Comment at: clang/include/clang/Basic/TokenKinds.def:381-383
+C2X_KEYWORD(bool                        , BOOLSUPPORT)
+C2X_KEYWORD(false                       , BOOLSUPPORT)
+C2X_KEYWORD(true                        , BOOLSUPPORT)
----------------
I'm very sorry for not noticing this until the last minute, but I think all three of these should be using `KEYWORD` instead of `C2X_KEYWORD`. We set the value for `BOOLSUPPORT` properly for C2x: https://github.com/llvm/llvm-project/blob/main/clang/lib/Basic/LangOptions.cpp#L196 so that should be a no-op change.

(Otherwise, it looks like these are C2x keywords but not C++ keywords, which seems rather strange)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131683/new/

https://reviews.llvm.org/D131683