[PATCH] D132503: [clang] Add cxx scope if needed for requires clause.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 25 11:29:14 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM! Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution?



================
Comment at: clang/docs/ReleaseNotes.rst:170
   This fixes `GH55601 <https://github.com/llvm/llvm-project/issues/55601>`_.
-
-
+- Class member variables are now in scope when parsing requires clauses. Fixes
+  `GH55216 <https://github.com/llvm/llvm-project/issues/55216>`_.
----------------



================
Comment at: clang/lib/Parse/ParseTemplate.cpp:293
+    if (Tok.is(tok::kw_requires)) {
+      CXXScopeSpec ScopeSpec = DeclaratorInfo.getCXXScopeSpec();
+      DeclaratorScopeObj DeclScopeObj(*this, ScopeSpec);
----------------
luken-google wrote:
> erichkeane wrote:
> > Not sure about this type, should this be a reference?
> Mm, good point. Fixed.
Great catch!!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132503/new/

https://reviews.llvm.org/D132503



More information about the cfe-commits mailing list