[PATCH] D132568: [clang][Sema] check default argument promotions for printf

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added inline comments.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:10133-10135
+  if (ImplicitMatch == ArgType::NoMatchPedantic ||
+      ImplicitMatch == ArgType::NoMatchTypeConfusion)
+    Match = ImplicitMatch;
----------------
nickdesaulniers wrote:
> Similarly, if `ImplicitMatch` can only be updated to one of these two values within the above `const ImplicitCastExpr *ICE = dyn_cast<ImplicitCastExpr>(E)` branch, does it make sense to additionally hoist this conditional check into that branch as well?
If we can do both suggestions, then `ImplicitMatch` can remain scoped to that branch, as it previously was.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132568/new/

https://reviews.llvm.org/D132568