[PATCH] D132503: Add cxx scope if needed for requires clause.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 25 08:49:54 PDT 2022


aaron.ballman added reviewers: erichkeane, clang-language-wg.
aaron.ballman added a comment.

FWIW, I think this looks correct as well. I've added some reviewers just in case there's something I've missed regarding concepts.



================
Comment at: clang/lib/Parse/ParseTemplate.cpp:293-301
+      DeclaratorScopeObj DeclScopeObj(*this, DeclaratorInfo.getCXXScopeSpec());
+      if (DeclaratorInfo.getCXXScopeSpec().isValid()) {
+        if (Actions.ShouldEnterDeclaratorScope(
+                getCurScope(), DeclaratorInfo.getCXXScopeSpec())) {
+          DeclScopeObj.EnterDeclaratorScope();
+        }
+      }
----------------
Can simplify even further with a new local.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132503/new/

https://reviews.llvm.org/D132503



More information about the cfe-commits mailing list