[PATCH] D132661: [clang] Make guard(nocf) attribute available only for Windows

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 25 08:14:03 PDT 2022


aaron.ballman added a comment.

Thanks for this! Can you also add test coverage for the change?



================
Comment at: clang/include/clang/Basic/Attr.td:402
 def TargetWebAssembly : TargetArch<["wasm32", "wasm64"]>;
+def TargetHasCFGuard : TargetSpec {
+  let CustomCode = [{ Target.getTriple().isOSWindows() }];
----------------
How about we name this one `TargetWindows` instead of making it specific to just one attribute?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132661/new/

https://reviews.llvm.org/D132661



More information about the cfe-commits mailing list