[clang] 9be8630 - Add a missing override keyword. NFC.

Benjamin Kramer via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 25 05:51:25 PDT 2022


Author: Benjamin Kramer
Date: 2022-08-25T14:50:28+02:00
New Revision: 9be8630ca9445b3370385bdbce9b7919f267e38a

URL: https://github.com/llvm/llvm-project/commit/9be8630ca9445b3370385bdbce9b7919f267e38a
DIFF: https://github.com/llvm/llvm-project/commit/9be8630ca9445b3370385bdbce9b7919f267e38a.diff

LOG: Add a missing override keyword. NFC.

clang/lib/Basic/Targets/X86.h:293:8: warning: 'shouldEmitFloat16WithExcessPrecision' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  bool shouldEmitFloat16WithExcessPrecision() const {
       ^
clang/include/clang/Basic/TargetInfo.h:915:16: note: overridden virtual function is here
  virtual bool shouldEmitFloat16WithExcessPrecision() const { return false; }
               ^

Added: 
    

Modified: 
    clang/lib/Basic/Targets/X86.h

Removed: 
    


################################################################################
diff  --git a/clang/lib/Basic/Targets/X86.h b/clang/lib/Basic/Targets/X86.h
index aef9f4a0676ec..7c1fe0d50fac0 100644
--- a/clang/lib/Basic/Targets/X86.h
+++ b/clang/lib/Basic/Targets/X86.h
@@ -290,7 +290,7 @@ class LLVM_LIBRARY_VISIBILITY X86TargetInfo : public TargetInfo {
     return false;
   }
 
-  bool shouldEmitFloat16WithExcessPrecision() const {
+  bool shouldEmitFloat16WithExcessPrecision() const override {
     return HasFloat16 && !hasLegalHalfType();
   }
 


        


More information about the cfe-commits mailing list