[clang] 5218a54 - [NFC] Fix a misleading comment CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION
Tobias Hieta via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 25 00:57:08 PDT 2022
Author: Tobias Hieta
Date: 2022-08-25T09:56:55+02:00
New Revision: 5218a542ac09ea97f789999681f4f1b90a3b835c
URL: https://github.com/llvm/llvm-project/commit/5218a542ac09ea97f789999681f4f1b90a3b835c
DIFF: https://github.com/llvm/llvm-project/commit/5218a542ac09ea97f789999681f4f1b90a3b835c.diff
LOG: [NFC] Fix a misleading comment CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION
Added:
Modified:
clang/tools/libclang/CMakeLists.txt
Removed:
################################################################################
diff --git a/clang/tools/libclang/CMakeLists.txt b/clang/tools/libclang/CMakeLists.txt
index 9a874ae6f85dc..c6b3b44a76334 100644
--- a/clang/tools/libclang/CMakeLists.txt
+++ b/clang/tools/libclang/CMakeLists.txt
@@ -3,11 +3,15 @@
# LLVM_VERSION_MAJOR.
# Please also see clang/tools/libclang/libclang.map
+# This option defaults to CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION
+# to ON - which means that it by default matches CLANG_VERSION_MAJOR
+#
+# TODO: This should probably not be a option going forward but we
+# we should commit to a way to do it. But due to getting this out
+# in LLVM 15.x we opted for a option.
if(NOT CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION)
- # default is to use the SOVERSION according to ABI...
set(LIBCLANG_SOVERSION 13)
else()
- # ... unless explicily overridden
set(LIBCLANG_SOVERSION ${CLANG_VERSION_MAJOR})
endif()
More information about the cfe-commits
mailing list