[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Michael Buch via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 25 00:52:14 PDT 2022


Michael137 added a comment.

In D128830#3746153 <https://reviews.llvm.org/D128830#3746153>, @aprantl wrote:

> I think we can "fix" the test with the following patch:
>
>   diff --git a/lldb/test/API/functionalities/unused-inlined-parameters/main.c b/lldb/test/API/functionalities/unused-inlined-parameters/main.c
>   index f2ef5dcc213d..9b9f95f6c946 100644
>   --- a/lldb/test/API/functionalities/unused-inlined-parameters/main.c
>   +++ b/lldb/test/API/functionalities/unused-inlined-parameters/main.c
>   @@ -7,6 +7,7 @@ __attribute__((always_inline)) void f(void *unused1, int used, int unused2) {
>    }
>    
>    int main(int argc, char **argv) {
>   -  f(argv, 42, 1);
>   +  char *undefined;
>   +  f(undefined, 42, 1);
>      return 0;
>   -}

Made the change to the test. Confirmed it passes with and without the patch. Feel free to push again


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128830/new/

https://reviews.llvm.org/D128830



More information about the cfe-commits mailing list