[PATCH] D119051: Extend the C++03 definition of POD to include defaulted functions
Reid Kleckner via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 24 16:07:11 PDT 2022
rnk added a subscriber: ayzhao.
rnk added a comment.
In D119051#3747201 <https://reviews.llvm.org/D119051#3747201>, @dblaikie wrote:
> So... my conclusion is that Clang's AArch64 appears to be correct for x86 as well, and we should just rename the function and use it unconditionally, removing any use of Clang's AST POD property in the MSVC ABI handling?
Sounds good to me, I think you did the hard work of verifying, thanks for that. :)
Anyway, removing this isPOD usage should be it's own patch, with tests. We should already have test coverage for aarch64 that can be reused. @ayzhao, can you help David with this? This is not C++20-related, but it is clang frontend related.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D119051/new/
https://reviews.llvm.org/D119051
More information about the cfe-commits
mailing list