[PATCH] D132617: [clang][deps] Minor ModuleDepCollector refactorings NFC
Jan Svoboda via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 24 15:56:27 PDT 2022
jansvoboda11 accepted this revision.
jansvoboda11 added a comment.
This revision is now accepted and ready to land.
LGTM with a nit.
================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:277
+ MDC.DirectPrebuiltModularDeps.insert(
+ std::make_pair(TopLevelModule, PrebuiltModuleDep{TopLevelModule}));
else
----------------
Nit: I think you should be able to drop `std::make_pair()` and use brace-initialization. Also applies to the other call to `insert` above.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132617/new/
https://reviews.llvm.org/D132617
More information about the cfe-commits
mailing list