[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types
Joseph Huber via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 24 14:50:43 PDT 2022
jhuber6 added a comment.
In D132607#3747394 <https://reviews.llvm.org/D132607#3747394>, @tra wrote:
>> Should these be merged into a public interface via Object/OffloadBinary.h?
>
> I'm all for consolidating relevant code.
Basically it would be a free function doing that `extractFromBuffer` does here. I would also need to define a wrapper around `OwningBinary<OffloadBinary>` as that's what I use in the linker wrapper.
I'm not sure if it would be easier to consolidate this before or after this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132607/new/
https://reviews.llvm.org/D132607
More information about the cfe-commits
mailing list