[PATCH] D132607: [OffloadPackager] Add ability to extract mages from other file types

Joseph Huber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 24 14:16:01 PDT 2022


jhuber6 created this revision.
jhuber6 added reviewers: saiislam, JonChesterfield, yaxunl, ronlieb, tra, jdoerfert.
Herald added a subscriber: mgorny.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.

A previous patch added support for extracting images from offloading
binaries. Users may wish to extract these files from the file types they
are most commonly emebedded in, such as an ELF or bitcode. This can be
difficult for the user to do manually, as these could be stored in
different section names potentially. This patch addsp support for
extracting these file types.

Note, this patch duplicated a lot of code from the `ClangLinkerWrapper`
that does a nearly identical extraction. Should these be merged into a
public interface via `Object/OffloadBinary.h`?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132607

Files:
  clang/test/Driver/offload-packager.c
  clang/tools/clang-offload-packager/CMakeLists.txt
  clang/tools/clang-offload-packager/ClangOffloadPackager.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132607.455372.patch
Type: text/x-patch
Size: 10535 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220824/76b86d5e/attachment-0001.bin>


More information about the cfe-commits mailing list