[PATCH] D113107: Support of expression granularity for _Float16.
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 24 11:58:18 PDT 2022
rjmccall added a comment.
Thank you! I think all the invariants look right here; just some minor comments now, and then it should be ready to commit.
================
Comment at: clang/lib/CodeGen/CGExprComplex.cpp:403
+ Builder.CreateStore(Val.second, ImagPtr, isVolatile);
+}
+
----------------
This looks to be dead code now, right?
================
Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2860
+ result = Builder.CreateFPTrunc(result, ConvertType(E->getType()),
+ "unpromotion");
+ return result;
----------------
Please use your `EmitUnPromotedValue` function here (and in the similar functions below).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113107/new/
https://reviews.llvm.org/D113107
More information about the cfe-commits
mailing list