[PATCH] D126907: Deferred Concept Instantiation Implementation Take 2

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 24 11:05:45 PDT 2022


Mordante added a comment.

In D126907#3740536 <https://reviews.llvm.org/D126907#3740536>, @erichkeane wrote:

> For example, this enable-modules flag isn't covered by my local check-cxx, which I went out of my way to run on this patch locally.

Unfortunately there are a lot of different options and combination of options to test libc++.
So it's indeed not possible to test all options with once check-cxx invocation.

In D126907#3746408 <https://reviews.llvm.org/D126907#3746408>, @erichkeane wrote:

> Fixing the assert was pretty easy, and fixing it revealed the same 8 failures from the buildbot above.

Great to hear you can reproduce the issue!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126907/new/

https://reviews.llvm.org/D126907



More information about the cfe-commits mailing list