[PATCH] D131683: Diagnosing the Future Keywords

Muhammad Usman Shahid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 24 04:01:29 PDT 2022


Codesbyusman added inline comments.


================
Comment at: clang/include/clang/Basic/TokenKinds.def:384
+C2X_KEYWORD(true                        , BOOLSUPPORT)
+C2X_KEYWORD(remove_quals                , KEYC2X)
+
----------------
aaron.ballman wrote:
> This is technically correct, but I think we should remove it until we go to implement that paper instead of introducing the keyword out of thin air here.
> 
> Btw, I think that should be `, 0` instead of `, KEYC2X` given the use of `C2X_KEYWORD`, right?
> This is technically correct, but I think we should remove it until we go to implement that paper instead of introducing the keyword out of thin air here.
> 
> Btw, I think that should be `, 0` instead of `, KEYC2X` given the use of `C2X_KEYWORD`, right?

Don't know much but what I understand that this is a keyword but not published officially by language but will be in future. so I think will be good to remove it or can add Fixme?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131683/new/

https://reviews.llvm.org/D131683



More information about the cfe-commits mailing list