[PATCH] D128830: [Pipelines] Introduce DAE after ArgumentPromotion

Wed Aug 24 02:33:08 PDT 2022

Michael137 added a comment.

FYI, this broke the LLDB build bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/46324/execution/node/74/log/

Looks like we're testing that unused parameters optimise out but that's not the case anymore

`AssertionError: '(void *) unused1 = <no location, value may have been optimized out>' not found in '(void *) unused1 = 0x000000016fdff4d0\n'`

Looks like with this patch DWARF contains this extra entry for the unused parameter:

  0x00000045:     DW_TAG_formal_parameter                                                                             
                    DW_AT_location    (0x00000000:                                                                    
                       [0x0000000100003f1c, 0x0000000100003f20): DW_OP_reg0 W0                                        
                       [0x0000000100003f20, 0x0000000100003f24): DW_OP_entry_value(DW_OP_reg0 W0), DW_OP_stack_value) 

whereas previously it was,

  0x00000045:     DW_TAG_formal_parameter                       
                    DW_AT_abstract_origin (0x00000061 "unused1")

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128830/new/

https://reviews.llvm.org/D128830