[PATCH] D131625: [HLSL] Entry functions require param annotation

Tue Aug 23 18:53:26 PDT 2022

beanz added inline comments.

================
Comment at: clang/test/SemaHLSL/Semantics/missing_entry_annotation.hlsl:1
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -fsyntax-only -hlsl-entry main -verify %s
+
----------------
beanz wrote:
> aaron.ballman wrote:
> > That's not needed, right?
> It shouldn't be but is because hlsl is missing from `FrontendOptions::getInputKindForExtension`. I'll get a patch up for that shortly.
Since the change for this was pretty trivial, I pushed it in rG887bafb503c59c5ecef831c679a2b114ee6ef338

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131625/new/

https://reviews.llvm.org/D131625