[PATCH] D128113: Clang: fix AST representation of expanded template arguments.

Tue Aug 23 17:37:27 PDT 2022

alexfh added a comment.

In D128113#3744296 <https://reviews.llvm.org/D128113#3744296>, @mizvekov wrote:

> In D128113#3744290 <https://reviews.llvm.org/D128113#3744290>, @alexfh wrote:
>
>> Do you have a practical example that would use the substitution index? I believe you had something in mind before you implemented this patch?
>
> Oh, yes, this is needed for / is going to culminate in the implementation of the project described in https://discourse.llvm.org/t/rfc-improving-diagnostics-with-template-specialization-resugaring/64294/11

The whole project seems like a great improvement in clang diagnostics, but I don't yet see how template parameter pack substitution indices fit into the whole picture. If different type parameters in a parameter pack differ only by some other type of suraring, would they be distinguishable in the current state? How do substitution indices affect this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128113/new/

https://reviews.llvm.org/D128113