[PATCH] D132486: SONAME introduce option CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION

Tue Aug 23 12:16:16 PDT 2022

jrtc27 requested changes to this revision.
jrtc27 added inline comments.
This revision now requires changes to proceed.

================
Comment at: clang/CMakeLists.txt:467
+option(CLANG_FORCE_MATCHING_LIBCLANG_SOVERSION
+  "Force the SOVERSION of libclang to be equal to CLANG_MAJOR" OFF)
+
----------------
OFF by default changes behaviour, which seems irresponsible so late in the release cycle

================
Comment at: clang/tools/libclang/CMakeLists.txt:6
+
+if(NOT CLANG_FORCE_MATCHING_LIBCLANG_VERSION)
+  # default is to use the SOVERSION according to ABI...
----------------
Here says VERSION, clang/CMakeLists.txt says SOVERSION

================
Comment at: clang/tools/libclang/CMakeLists.txt:14-17
+# TODO: harmonize usage of LIBCLANG_SOVERSION / LIBCLANG_LIBARY_VERSION
+#       below; this was added under time-pressure to avoid reverting the
+#       better default from LLVM 14 for LLVM 15.0.0-rc3, hence no time
+#       to clean up previous inconsistencies.
----------------
This is highly subjective. Many believe the default was worse due to (a) confusion (b) technical issues when coinstalling multiple LLVM versions. Ping-ponging like this is just creating a mess.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132486/new/

https://reviews.llvm.org/D132486