[PATCH] D131625: [HLSL] Entry functions require param annotation

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 23 11:40:54 PDT 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM though I had a question about the test's RUN line.



================
Comment at: clang/test/SemaHLSL/Semantics/missing_entry_annotation.hlsl:1
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -fsyntax-only -hlsl-entry main -verify %s
+
----------------
That's not needed, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131625/new/

https://reviews.llvm.org/D131625



More information about the cfe-commits mailing list