[PATCH] D132430: [clang][modules] Track affecting modules

[Ben Langmuir via Phabricator via cfe-commits]

benlangmuir added inline comments.


================
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:311
+    if (!MDC.isPrebuiltModule(M))
+      DirectModularDeps.insert(M);
+
----------------
If using eager loading, this will cause us to load the module, right? Does that behaviour match the implicit build?


================
Comment at: clang/test/ClangScanDeps/modules-incomplete-umbrella.c:82
+// CHECK_TU-NEXT:       "command-line": [
+// CHECK_TU:            ],
+// CHECK_TU-NEXT:       "file-deps": [
----------------
The test should probably cover the imports in the command-lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132430/new/

https://reviews.llvm.org/D132430