[PATCH] D132461: [clang-tidy] Add cppcoreguidelines-avoid-do-while check

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 23 07:44:17 PDT 2022


carlosgalvezp added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-do-while.rst:21
+
+The check implements
+`rule ES.75 of C++ Core Guidelines <https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Res-do>`_.
----------------
Eugene.Zelenko wrote:
> Links usually placed at the end.
I think having the link after the options would make it a bit disconnected. Instead I typically find Options at the very end, after the description.

See for example: 
https://clang.llvm.org/extra/clang-tidy/checks/cppcoreguidelines/owning-memory.html

WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132461/new/

https://reviews.llvm.org/D132461



More information about the cfe-commits mailing list