[clang] ea0549d - [OffloadPackager] Add necessary move statement on returned value

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 23 06:45:49 PDT 2022


Author: Joseph Huber
Date: 2022-08-23T08:45:30-05:00
New Revision: ea0549d41bc44f60db6a2fb9e0f32e752d47e177

URL: https://github.com/llvm/llvm-project/commit/ea0549d41bc44f60db6a2fb9e0f32e752d47e177
DIFF: https://github.com/llvm/llvm-project/commit/ea0549d41bc44f60db6a2fb9e0f32e752d47e177.diff

LOG: [OffloadPackager] Add necessary move statement on returned value

Summary:
Some older compilers cannot automatically elide the returned vector of
unique pointers, causing build errors. This patch explicitly moves the
returned value instead which should solve the problem.

Added: 
    

Modified: 
    clang/tools/clang-offload-packager/ClangOffloadPackager.cpp

Removed: 
    


################################################################################
diff  --git a/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp b/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
index 0f90263d09345..b8d1565689f88 100644
--- a/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
+++ b/clang/tools/clang-offload-packager/ClangOffloadPackager.cpp
@@ -143,7 +143,7 @@ extractOffloadFiles(MemoryBufferRef Contents) {
     Binaries.emplace_back(std::move(*BinaryOrErr));
   }
 
-  return Binaries;
+  return std::move(Binaries);
 }
 
 static Error unbundleImages() {


        


More information about the cfe-commits mailing list