[PATCH] D132324: [RFC] Remove support for building libc++ with `LLVM_ENABLE_PROJECTS`

Tue Aug 23 05:46:57 PDT 2022

ldionne added a comment.

In D132324#3742406 <https://reviews.llvm.org/D132324#3742406>, @aaron.ballman wrote:

> For clarity, @ldionne are you requesting that these changes be reverted due to being incomplete, or do you prefer this be fixed forward?

Sorry, I left no action item on my end after my first comment. I'm wrapping my head around this change and the other changes that followed D132298 <https://reviews.llvm.org/D132298> and D132411 <https://reviews.llvm.org/D132411> first, and I'll post here what I think we should do. I've also seen some internal fallout of this change and I suspect I'm not alone.

Like I said, I greatly appreciate that folks took the lead to push this removal forward, however it should have been under review for more than 24h on a week-end. Concretely, what I planned on doing was turn the `message(WARNING` into `message(ERROR` as a dye test without changing anything else, and then turn it back on to `message(WARNING` to give folks a bit of time to fix their up/downstream CI systems (to avoid them being red for too long).

I'll post here again when I've wrapped my head around this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132324/new/

https://reviews.llvm.org/D132324